Use Servlet API 3.0 HttpServletRequest.getPart to process form data#492
Open
tenzap wants to merge 2 commits into
Open
Use Servlet API 3.0 HttpServletRequest.getPart to process form data#492tenzap wants to merge 2 commits into
tenzap wants to merge 2 commits into
Conversation
tenzap
force-pushed
the
servletApi3.0-getPart
branch
from
3ff6efb to
e330858
Compare
Fixes: w3c#455 - Add @MultipartConfig annotation - use HttpServletRequest.getPart to get the form data
tenzap
force-pushed
the
servletApi3.0-getPart
branch
from
e330858 to
f473ddd
Compare
Contributor
Author
|
@ylafon , it builds fine now, but I don't know if this would still work with jigsaw. |
Member
Yes, the issue is that Jigsaw is still stuck in 2.5 |
Contributor
Author
|
If you have a better fix for #455 that would still work with jigsaw, I would prefer that, instead of maintaining the changes of this PR in a debian-specific patch. Or maybe jigsaw can use the jar that adds support for servlet api 4.0.1? BTW, any update on #449 ? It would be great to have that done for the next release of css-validator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #455
Please review carefully since my java & servlet experience is low.
I have no idea if this would still work with jigsaw server since this requires Servlet API >= 3.0