feat(wasm): expand test suite, unwrap WebAssembly.Global and enable js-string builtins#22674
Open
guybedford wants to merge 1 commit into
Open
feat(wasm): expand test suite, unwrap WebAssembly.Global and enable js-string builtins#22674guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
…or direct imports Direct .wasm imports now expose exported WebAssembly.Global values unwrapped to their JS value, and support wasm-to-wasm global imports via a two-layer module split: a raw layer owns the instance and exposes globals as WebAssembly.Global objects, while the user-facing module re-exports the raw layer and unwraps globals (preserving live cells for wasm-to-wasm imports). Also enable the JS String Builtins and Imported String Constants proposals on compile/instantiate, matching the WebAssembly/ES Module Integration loader.
guybedford
force-pushed
the
feat/wasm-esm-integration
branch
from
7ba7032 to
7b3269d
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to the ESM Integration PR, to enable direct
.wasmimports exposing exportedWebAssembly.Globalvalues unwrapped to their JS value, while retaining a backing table to support wasm-to-wasm global imports. This is done via a two-layer module split: a raw layer owns the instance and exposes globals as WebAssembly.Global objects, while the user-facing module re-exports the raw layer and unwraps globals (preserving live cells for wasm-to-wasm imports).This PR also enables the JS String Builtins and Imported String Constants proposals on compile/instantiate, matching the spec and Node.js implementation.