fix: align gfmrun example counter with actual runnable count#2369
Open
dearchap wants to merge 1 commit into
Open
fix: align gfmrun example counter with actual runnable count#2369dearchap wants to merge 1 commit into
dearchap wants to merge 1 commit into
Conversation
- Replace naive 'package main' counter with proper code fence parser that matches gfmrun's logic (go blocks with package main, exact sh/bash) - Change informational sh examples to sh-session so they aren't run by gfmrun (they reference ./cmd/myapp which doesn't exist in CI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the naive
strings.Contains(line, "package main")counter with a proper code-fence parser that mirrors gfmrun's own logic:goblocks only when their first code line ispackage mainshandbashblocks exactly (notsh-session)shexamples inbinary-size.mdtosh-session(they reference./cmd/myappwhich does not exist in CI)path-and-walk.md(broken imports, missingcontext, wrongSubcommandsfield name)Closes #2362