fix: respect input_draft when updating existing release#801
Open
godfengliang wants to merge 1 commit into
Open
fix: respect input_draft when updating existing release#801godfengliang wants to merge 1 commit into
godfengliang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #795
Problem
When updating an existing draft release to a prerelease, the
draftfield is hardcoded toexistingRelease.draft(alwaystruefor a draft release). This means the release cannot be converted from draft to published prerelease even whendraftinput is explicitly set tofalseor omitted.Root Cause
In
src/github.tsline 582, thedraftfield in theupdateReleasecall usesexistingRelease.draftdirectly, ignoring the user'sinput_draftsetting. Compare this to theprereleasefield on lines 569-570, which correctly respectsconfig.input_prerelease.Fix
Mirror the
prereleaselogic fordraft:Before:
After:
This ensures that when
input_draftis explicitly provided, it overrides the existing value. When not provided, the existing draft status is preserved (backward compatible).Testing
The user's reproduction case should now work:
draft: truedraft: false(or omit) andprerelease: true