gh-151483: Make PyCodeObject._co_unique_id conditional on `Py_GIL_D…#151484
Open
weixlu wants to merge 1 commit into
Open
gh-151483: Make PyCodeObject._co_unique_id conditional on `Py_GIL_D…#151484weixlu wants to merge 1 commit into
PyCodeObject._co_unique_id conditional on `Py_GIL_D…#151484weixlu wants to merge 1 commit into
Conversation
…_GIL_DISABLED`
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyCodeObject._co_unique_idis currently declared unconditionally, but its usage is entirely in free-threaded code paths. So maybe we can make_co_unique_idonly present whenPy_GIL_DISABLEDis enabled.I have run
./python -m testand it seems fine.PyCodeObject._co_unique_idconditional onPy_GIL_DISABLED#151483