ci(ui): gate E2E tests with opt-in label#11569
Draft
HugoPBrito wants to merge 3 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Refs #11183.
This PR addresses the High finding for
ui-e2e-tests-v2.yml: cloud-backed UI E2E credentials were available to PR-controlled code whenever the workflow ran.Description
pushexecution formasterandv5.*, where UI E2E runs independently of labels.run-ui-e2elabel.OWNER,MEMBER, andCOLLABORATORPRs without checking out or executing PR code.ui-e2e-cloudenvironment.Note: the label gate is a maintainer-controlled opt-in/risk-acceptance mechanism, not full isolation from PR-controlled code.
Steps to review
.github/workflows/ui-e2e-tests-v2.yml.pull_requestruns require therun-ui-e2elabel beforeimpact-analysisande2e-testsrun.pushtomaster/v5.*runs independently of labels.auto-label-trusted-prdoes not checkout or execute PR code and only labels trusted author associations.e2e-testsjob usesenvironment: ui-e2e-cloud.Validation performed:
git diff --checkChecklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.