Skip to content

🌱 Apply cluster TLS profile to outgoing HTTP client#2767

Open
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:use-tls-profile-for-client
Open

🌱 Apply cluster TLS profile to outgoing HTTP client#2767
tmshort wants to merge 1 commit into
operator-framework:mainfrom
tmshort:use-tls-profile-for-client

Conversation

@tmshort

@tmshort tmshort commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Use the configured TLS profile (set via --tls-profile flags) for the catalogd HTTP client, consistent with how the metrics server TLS is configured. Falls back to TLS 1.2 minimum when no profile is set.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings June 15, 2026 16:07
@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2e77886
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a3053cb3d38e50008183d36
😎 Deploy Preview https://deploy-preview-2767--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested review from oceanc80 and pedjak June 15, 2026 16:08
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Applies the cluster’s configured TLS profile to the outgoing HTTP client so catalogd’s client behavior matches the TLS configuration approach used elsewhere (e.g., metrics server), while keeping a TLS 1.2 minimum as a fallback.

Changes:

  • Import TLS profile helper and apply it to the HTTP client TLS config when available.
  • Retain TLS 1.2 minimum as the default baseline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/shared/util/http/httputil.go Outdated
Comment thread internal/shared/util/http/httputil.go Outdated
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.76%. Comparing base (8807a64) to head (2e77886).

Files with missing lines Patch % Lines
internal/shared/util/http/httputil.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.03%     
==========================================
  Files         149      149              
  Lines       11382    11386       +4     
==========================================
  Hits         7602     7602              
- Misses       3221     3223       +2     
- Partials      559      561       +2     
Flag Coverage Δ
e2e 35.14% <50.00%> (+0.04%) ⬆️
experimental-e2e 52.34% <50.00%> (+0.12%) ⬆️
unit 52.12% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort force-pushed the use-tls-profile-for-client branch from df8aa6b to 79f5990 Compare June 15, 2026 19:04
@tmshort tmshort requested a review from Copilot June 15, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread internal/shared/util/http/httputil.go Outdated
Comment thread internal/shared/util/http/httputil.go Outdated
Use the configured TLS profile (set via --tls-profile flags) for the
catalogd HTTP client, consistent with how the metrics server TLS is
configured. Falls back to TLS 1.2 minimum when no profile is set.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort force-pushed the use-tls-profile-for-client branch from 79f5990 to 2e77886 Compare June 15, 2026 19:34
@tmshort tmshort requested a review from Copilot June 15, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants