Skip to content

crypto: reject resizable backing stores in Web Crypto buffer parameters#63925

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:reject-resizable-stores
Open

crypto: reject resizable backing stores in Web Crypto buffer parameters#63925
panva wants to merge 1 commit into
nodejs:mainfrom
panva:reject-resizable-stores

Conversation

@panva

@panva panva commented Jun 15, 2026

Copy link
Copy Markdown
Member

Aligns the BigInteger and BufferSource Web IDL converters with the default backing-store validation, rejecting views over resizable ArrayBuffers instead of silently allowing them.

@panva panva added crypto Issues and PRs related to the crypto subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. webcrypto labels Jun 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 15, 2026
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 15, 2026
Aligns the BigInteger and BufferSource Web IDL converters with the
default backing-store validation, rejecting views over resizable
ArrayBuffers instead of silently allowing them.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the reject-resizable-stores branch from a662876 to 9b15159 Compare June 15, 2026 11:25
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2026
@panva

panva commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

cc @nodejs/tsc for semver-major PRs that contain breaking changes and should be released in the next major version.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants