crypto: throw on uninitialized DH computeSecret#63922
Open
panva wants to merge 1 commit into
Open
Conversation
Reject DiffieHellman computeSecret() when the instance does not have private key material instead of returning an empty buffer. Fixes: nodejs#63674 Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
panva
added
the
semver-major
Member
Author
|
cc @nodejs/tsc for
semver-major
|
tniessen
approved these changes
Jun 15, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
approved these changes
Jun 15, 2026
panva
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject DiffieHellman computeSecret() when the instance does not have private key material instead of returning an empty buffer.
Fixes: #63674