chore: enforce code formatting with @stylistic, mirroring nodejs/node#63
Merged
Merged
Conversation
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds machine-enforced JS/TS formatting via
@stylistic/eslint-plugin, with rules mirrored from nodejs/node's eslint config — single quotes, trailing commas, 2-space indent, 120 max-len.Two commits:
eslint --fix, no behavior change.Deviation from upstream: this repo has TypeScript, so it uses the unified
@stylistic/eslint-plugininstead of the JS-only-jspackage (same rules).No new CI — the existing
lint.ymlrunsnpm run linton every push/PR, so it now enforces these rules.npm run lintandnpm run node:test(40/40) pass.