refactor: move dataviewSharedArrayBuffer gate out of experimentalFeatures#62
Merged
legendecas merged 1 commit intoJun 12, 2026
Conversation
legendecas
approved these changes
Jun 12, 2026
Member
|
Would you mind address the conflicts? Thanks! |
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
force-pushed
the
refactor/dataview-runtime-feature-flag
branch
from
c02f7de to
1e36360
Compare
Contributor
Author
|
@legendecas conflicts resolved. Thanks |
legendecas
approved these changes
Jun 12, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39.
napi_create_dataviewis a stable (non-experimental) Node-API. Its SharedArrayBuffer support is version-dependent — it landed in Node.js v24.13.1 and v25.4.0 (nodejs/node#60473) — but that is a runtime-version behavior, not a feature behindNAPI_EXPERIMENTAL. So the gate did not belong inexperimentalFeatures.This moves the
dataviewSharedArrayBufferflag into a newruntimeFeaturesglobal for version-dependent behaviors of stable APIs. The version math stays in the Node harness; tests (and other implementors) just read a boolean, keeping test files runtime-agnostic.implementors/node/features.js— addruntimeFeatures, move the flag out ofexperimentalFeatureseslint.config.js— allowruntimeFeaturesin test filestests/js-native-api/test_dataview/test_sharedarraybuffer.js— gate onruntimeFeatures.dataviewSharedArrayBuffer