fix: reject negative indent instead of panicking#2746
Open
StressTestor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2329.
the problem
a negative indent crashes yq instead of erroring cleanly:
the
-I/--indentflag is an int with no lower bound, so a negative value flows straight through to the yaml encoder'sSetIndent, which panics. a bad flag value should be a clean error, not a stack trace.the fix
reject a negative indent in
validateCommandFlags(the same place the other flag-combo checks live), before any encoding happens:after:
-I=0stays valid (it's documented for one-line json), so the guard is< 0, not<= 0. validating at the flag layer covers every output format at once rather than patching each encoder.tests
extended
TestValidateCommandFlagswith a negative case (fails without the guard, passes with it) and a zero case (pins that-I=0stays valid). existing cases unaffected.