fix(macljqCtrl): add CropToScreen helper + crop-origin coord hints#614
Open
wjl2023 wants to merge 1 commit into
Open
fix(macljqCtrl): add CropToScreen helper + crop-origin coord hints#614wjl2023 wants to merge 1 commit into
wjl2023 wants to merge 1 commit into
Conversation
On macOS the screenshot path lacked a counterpart to win32's ClientToScreen. Detecting a target inside a cropped GrabScreen(bbox) image and feeding the in-image (px,py) straight to Click silently mis-clicks because the crop-origin offset is dropped. - add CropToScreen(bbox, x, y): in-crop coords -> absolute physical coords (pure crop-origin add, no scaling) - GrabScreen docstring: warn about the crop-origin trap and not to hand-roll screencapture -R (it takes logical points) - Click 0%-pixel-change warning now names the common causes - ljqCtrl_sop.md: add macOS subsection mirroring the win32 trap note
wjl2023
force-pushed
the
fix/macos-crop-coord-helper
branch
from
7582e6c to
d1e1618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the screenshot path lacked a counterpart to win32's ClientToScreen. Detecting a target inside a cropped GrabScreen(bbox) image and feeding the in-image (px,py) straight to Click silently mis-clicks because the crop-origin offset is dropped.