Skip to content

[en] Fix ClusterTrustBundle API reference link#56093

Open
popsiclelmlm wants to merge 1 commit into
kubernetes:mainfrom
popsiclelmlm:fix/certificates-clustertrustbundle-link
Open

[en] Fix ClusterTrustBundle API reference link#56093
popsiclelmlm wants to merge 1 commit into
kubernetes:mainfrom
popsiclelmlm:fix/certificates-clustertrustbundle-link

Conversation

@popsiclelmlm

Copy link
Copy Markdown
Contributor

Summary

  • Update the English Certificate Signing Requests page metadata for ClusterTrustBundle from certificates.k8s.io/v1alpha1 to certificates.k8s.io/v1beta1.
  • This lets the page-api-reference shortcode resolve the existing ClusterTrustBundle API reference page instead of rendering %!s(<nil>).

Reproduction

On /docs/reference/access-authn-authz/certificate-signing-requests/#what-s-next, the "Read about the ClusterTrustBundle API" bullet rendered %!s(<nil>) instead of a link.

Root cause

The page front matter still pointed ClusterTrustBundle at certificates.k8s.io/v1alpha1, but the generated English API reference page is content/en/docs/reference/kubernetes-api/certificates/cluster-trust-bundle-v1beta1.md with apiVersion: "certificates.k8s.io/v1beta1". The shortcode builds API reference links by matching kind and apiVersion, so the stale metadata produced no map entry for ClusterTrustBundle.

Changes

  • Change the English page api_metadata entry for ClusterTrustBundle to certificates.k8s.io/v1beta1.
  • Remove trailing whitespace on that front matter line.
  • Keep this PR scoped to the English page; the zh-cn page can be handled in a separate localization PR as suggested on the issue.

Tests

  • awk 'prev ~ /apiVersion: "certificates.k8s.io\\/v1beta1"/ && $0 ~ /kind: "ClusterTrustBundle"/ {found=1} {prev=$0} END {if (!found) exit 1; print "page metadata points to ClusterTrustBundle v1beta1"}' content/en/docs/reference/access-authn-authz/certificate-signing-requests.md
  • awk 'BEGIN{inmeta=0} /^---$/ {if (!inmeta) {inmeta=1; next} else {inmeta=0; exit}} inmeta && /apiVersion: "certificates.k8s.io\\/v1beta1"/ {version=1} inmeta && /kind: "ClusterTrustBundle"/ {kind=1} END {if (!(version && kind)) exit 1; print "API reference front matter is ClusterTrustBundle v1beta1"}' content/en/docs/reference/kubernetes-api/certificates/cluster-trust-bundle-v1beta1.md
  • git diff --check origin/main..HEAD

Screenshots/Logs

  • Not applicable; this is a front matter metadata fix.
  • Local Hugo render was not run because hugo is not installed in this environment.

Issue

Related to #56092.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from enj and mikedanese June 11, 2026 19:29
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2026
@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1fba09c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6a2b0dc5a483d2000893a728
😎 Deploy Preview https://deploy-preview-56093--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2026

@Arhell Arhell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2026
@Caesarsage

Copy link
Copy Markdown
Contributor

Thank you for the contribution, @popsiclelmlm!

Did you use AI to generate these changes? If yes, project policy requires disclosing the tooling used in the PR description.

I'm asking because the Screenshots/Logs section suggests this wasn't built or tested locally before opening the PR, a common pattern with AI-generated submissions. Even for a small change, please set up your environment and verify the result; the contribution guide walks through the local setup.

Holding until the AI question is answered, anyone can /unhold and approve after that.

/lgtm cancel
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2026
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2026
@k8s-ci-robot k8s-ci-robot requested a review from Arhell June 12, 2026 07:02
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants