fix: paginate ECR DescribeImages to retrieve all image tags#441
Open
matteosilv wants to merge 6 commits into
Open
fix: paginate ECR DescribeImages to retrieve all image tags#441matteosilv wants to merge 6 commits into
matteosilv wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds pagination support to the ECR image tag listing so all images/tags are returned across multiple DescribeImages pages.
Changes:
- Refactors
DescribeImagescall to loop over pages usingNextToken. - Accumulates tags across pages into a single map before returning results.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+67
to
70
| images, err := client.DescribeImages(ctx, input) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to describe images: %s", err) | ||
| } |
Comment on lines
+93
to
+96
| if images.NextToken == nil { | ||
| break | ||
| } | ||
| input.NextToken = images.NextToken |
Collaborator
|
Thanks for the Contribution @matteosilv Can you please review the copilot comments as above and see if they are relevant, thank you! :) |
- Use %w for error wrapping so callers can unwrap with errors.Is/As - Also break on empty-string NextToken to guard against non-nil empty token edge case
Comment on lines
+66
to
70
| for { | ||
| images, err := client.DescribeImages(ctx, input) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to describe images: %w", err) | ||
| } |
Comment on lines
+93
to
+96
| if images.NextToken == nil || aws.ToString(images.NextToken) == "" { | ||
| break | ||
| } | ||
| input.NextToken = images.NextToken |
Author
|
@joshw123 both looks valid and I addressed them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.