fix report generation crash and pull descriptions from commons api#536
Open
ayushshukla1807 wants to merge 1 commit into
Open
fix report generation crash and pull descriptions from commons api#536ayushshukla1807 wants to merge 1 commit into
ayushshukla1807 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Final Campaign Report generation and missing metadata
While testing the final campaign report generation, I noticed the process would crash due to a broken
to_dict()call on theEntrymodel insidebuild_campaign_report.I have resolved the crash by switching to the correct
to_details_dict(with_uploader=True).Additionally, the report was missing the image descriptions (as noted in the
TODO.md). Since we don't store the full Commons description in our DB, I added a lightweight helper to fetch theextmetadatadirectly from the Wikimedia Commons API to dynamically inject thedescriptioninto the final JSON output.Tested locally and the final report now generates flawlessly with the missing metadata included!