chore: an entry for google-cloud-pom-parent in versions.txt#13483
Draft
zhumin8 wants to merge 3 commits into
Draft
chore: an entry for google-cloud-pom-parent in versions.txt#13483zhumin8 wants to merge 3 commits into
zhumin8 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version-update tracking comments across numerous pom.xml files to reference google-cloud-pom-parent instead of google-cloud-java. Additionally, it registers the google-cloud-pom-parent module in librarian.yaml and versions.txt. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this repo,
google-cloud-pom-parentartifact version are tracked with same marker asgoogle-cloud-java. However in partial releases,google-cloud-pom-parentare not bump together withgoogle-cloud-java. This change is to separate and create a tracking version forgoogle-cloud-pom-parent.This change needs to coordinate with librarian.yaml change.
Changes in this PR:
google-cloud-pom-parent, use the new markergoogle-cloud-pom-parentin gapic-libraries-bom/pom.xml for now to avoid generation diff mid change. This file is generated from template. Will update this occurrence in same PR when updating librarian version that includes necessary changes on librarian side..For googleapis/librarian#6411