fix(auth): close BufferedReader when reading subject token from TEXT file#13466
Open
lsirac wants to merge 2 commits into
Open
fix(auth): close BufferedReader when reading subject token from TEXT file#13466lsirac wants to merge 2 commits into
lsirac wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a try-with-resources block in FileIdentityPoolSubjectTokenSupplier.java to ensure that the BufferedReader is properly closed when parsing text-formatted tokens. Additionally, a comprehensive test suite FileIdentityPoolSubjectTokenSupplierTest has been added to verify token parsing behavior, exception handling, and proper stream closure across various formats (text and JSON). There are no review comments, and I have no additional feedback to provide.
macastelaz
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves resource leak in FileIdentityPoolSubjectTokenSupplier by wrapping BufferedReader in a try-with-resources statement under TEXT formats. Fully covered with new JUnit 5 tests.