fix(storage): add Close() support to AsyncWriterConnectionResumed#16163
fix(storage): add Close() support to AsyncWriterConnectionResumed#16163kalragauri wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the Close functionality for AsyncWriterConnectionResumed, adding the necessary state tracking, step functions, and resume handling, along with comprehensive unit tests. The review feedback suggests optimizing performance by passing Status objects by value and moving them in OnClose and SetClosed to avoid unnecessary copies, and correcting the misspelled test suite name WriteConnectionResumed to WriterConnectionResumed in the new tests.
2b28218 to
1da8c41
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16163 +/- ##
========================================
Coverage 92.20% 92.21%
========================================
Files 2264 2264
Lines 209092 209324 +232
========================================
+ Hits 192802 193028 +226
- Misses 16290 16296 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This is a follow-up to #16112. It implements the
Close()API inAsyncWriterConnectionResumedand its internal state managerAsyncWriterConnectionResumedState. This allows resumed async uploads to perform a clean half-close.This PR is similar to the Close implementation for the buffered writer in #16145.