stageJoiner optimizations#60
Merged
Merged
Conversation
needFilePipe() and validate() each call Stage.Requirements() for the adjacent stages, so a stage's requirements can be computed/allocated twice during startup. Caching the result on the joiner lets us call Requirements() only once.
Reorder Start() to run stageJoiner.validate() before createPipe(), and make validate() decide whether a stream is "connected" from the pipeline topology (the presence of an adjacent stage or an already-set input/output stream). This lets us reject an invalid pipeline without allocating any io.Pipe() objects, and in the case of os.Pipe(), doing the system calls to create OS-level file descriptors.
There was a problem hiding this comment.
Pull request overview
This PR optimizes pipeline stage-joining by caching each stage’s Requirements() and validating stream compatibility earlier, reducing repeated computation and avoiding unnecessary pipe allocation when stages are incompatible.
Changes:
- Cache
Stage.Requirements()instageJoiner(prevStageReq/nextStageReq) and reuse it for pipe selection and validation. - Update
stageJoiner.validate()to reason about whether streams are logically connected (via adjacent stages or pre-supplied stdin/stdout) rather than only checking already-created pipes. - Reorder
Pipeline.Start()to validate joiners before creating inner pipes.
Show a summary per file
| File | Description |
|---|---|
| pipe/stage_joiner.go | Adds cached requirements fields and updates validation/pipe-selection to use them. |
| pipe/pipeline.go | Stores cached requirements into joiners and validates joiners before allocating inner pipes. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two suggestions found while reviewing #59, both oriented around allocating less where possible.
/cc @mhagger