Fix IFC private repository labels#2695
Open
RossTarrant wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the IFC (Information Flow Control) labeling behavior for issue list/search (and other multi-repo search-style outputs) so that private repository results are labeled private-trusted rather than private-untrusted, and adjusts related documentation/comments plus unit tests accordingly.
Changes:
- Update
pkg/ifclabel helpers to returnPrivateTrusted()for private issue list/search results. - Refresh IFC-related comments in search/list code paths to reflect the new private-trusted semantics.
- Add/adjust unit tests to assert the updated IFC integrity/confidentiality expectations.
Show a summary per file
| File | Description |
|---|---|
| pkg/ifc/ifc.go | Changes private issue list/search label functions to return PrivateTrusted() and updates associated IFC join documentation. |
| pkg/ifc/ifc_test.go | Adds focused unit coverage for list/search label integrity/confidentiality outcomes. |
| pkg/github/search.go | Updates inline comments describing IFC joining behavior for repository/code/commit searches. |
| pkg/github/search_test.go | Updates IFC insiders-mode expectations for search_repositories when private repos are present. |
| pkg/github/repositories.go | Updates inline comments for joined IFC labeling in starred-repo listing. |
| pkg/github/issues_test.go | Updates IFC insiders-mode expectations for issue read/search/list flows involving private repositories. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 7
Keep joined search integrity conservative for mixed public and private results, and split user-authored repo content from list_issues private-trusted labeling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
RossTarrant
force-pushed
the
rosstarrant/fix-ifc-private-labels
branch
from
782c706 to
c34ff37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
script/lint && script/testgo test -race ./pkg/ifc ./pkg/github