Standardize README prerequisites across all SDK languages#1636
Standardize README prerequisites across all SDK languages#1636scottaddie wants to merge 8 commits into
Conversation
Move the .NET README requirements section above installation, rename it to prerequisites, and clarify the runtime requirement as any .NET Standard 2.0-compatible implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Reorganizes the .NET SDK README to surface runtime requirements up front and clarifies framework compatibility so users don’t incorrectly infer that .NET 8 is required for all use cases.
Changes:
- Adds a new Prerequisites section before Installation.
- Updates wording to state support for any .NET Standard 2.0-compatible implementation and links to Microsoft Learn guidance.
- Removes the older “Requirements” section previously located near the bottom of the README.
Show a summary per file
| File | Description |
|---|---|
| dotnet/README.md | Moves requirements into a Prerequisites section and clarifies .NET Standard 2.0 compatibility with an external reference link. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This comment has been minimized.
This comment has been minimized.
|
@copilot Update this PR to also address the suggestion in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Done. Applied the consistent
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 871.4K
|
@copilot update this PR to address the suggestions in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Done. Updated |
This comment has been minimized.
This comment has been minimized.
|
@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Fixed in the latest commit — removed the stray trailing period from |
This comment has been minimized.
This comment has been minimized.
|
@copilot update the PR to address the minor nitpick mentioned in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Done. Updated Node.js, Python, and .NET Prerequisites sections to use |
This comment has been minimized.
This comment has been minimized.
stephentoub
left a comment
There was a problem hiding this comment.
Other than the .NET issue, LGTM
…SDK READMEs Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
|
|
||
| ## Prerequisites | ||
|
|
||
| To use the SDK: |
There was a problem hiding this comment.
@copilot In each of the language files, update the "To use the SDK:" text to "To use the SDK, you'll need:"
There was a problem hiding this comment.
Done — updated all six SDK READMEs to use "To use the SDK, you'll need:" in the latest commit.
…READMEs Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
|
|
||
| - Java 17 or later. **JDK 25 recommended**. The distributed jar is a multi-release jar (MR-JAR) and is compiled on JDK 25 with `maven.compiler.release` set to 17. This means, when run on JDK 25 and later, the SDK automatically uses virtual threads for its default internal executor. | ||
| - GitHub Copilot CLI 1.0.55-5. or later installed and in `PATH` (or provide custom `cliPath`) | ||
| - GitHub Copilot CLI 1.0.55-5 or later installed and in `PATH` (or provide custom `cliPath`) |
There was a problem hiding this comment.
Do we not bundle it with Java as well?
| To use the SDK, you'll need: | ||
|
|
||
| - Node.js ^20.19.0 or >=22.12.0 | ||
| - GitHub Copilot CLI installed and in `PATH` (or provide a custom `connection`) |
There was a problem hiding this comment.
Don't we bundle it for node as well?
| To use the SDK, you'll need: | ||
|
|
||
| - Python 3.11+ | ||
| - GitHub Copilot CLI installed and in `PATH` (or provide a custom `connection=RuntimeConnection.for_stdio(path=...)`) |
There was a problem hiding this comment.
Don't we bundle it for python as well?
| To use the SDK, you'll need: | ||
|
|
||
| - Rust 1.94.0 or later | ||
| - GitHub Copilot CLI: bundled by default via the `bundled-cli` feature (see [Features](#features)); or supply via `COPILOT_CLI_PATH` |
There was a problem hiding this comment.
Why do we need to list it as a prereq given that it's bundled by default?
Cross-SDK consistency review ✅This PR does an excellent job standardizing prerequisites structure across all six SDK implementations. Here's the consistency checklist:
One minor observation (pre-existing, not introduced by this PR): Overall, the structural changes are clean, symmetric, and consistently applied. No cross-SDK gaps to address.
|
SDK READMEs lacked consistent structure and placement for prerequisites. The .NET README also incorrectly listed the CLI as a prerequisite despite the SDK bundling it.
Changes
"To use the SDK:"lead-in sentence before the prerequisites bullet list indotnet,nodejs,python,go,rust, andjavaREADMEs## Requirements→## Prerequisites; move before## Installation### Runtime requirements(nested under Installation) to a top-level## Prerequisitessection## Prerequisitessections before Installation / Quick Start