Skip to content

Standardize README prerequisites across all SDK languages#1636

Open
scottaddie wants to merge 8 commits into
mainfrom
scottaddie/readme-prerequisites
Open

Standardize README prerequisites across all SDK languages#1636
scottaddie wants to merge 8 commits into
mainfrom
scottaddie/readme-prerequisites

Conversation

@scottaddie

@scottaddie scottaddie commented Jun 11, 2026

Copy link
Copy Markdown

SDK READMEs lacked consistent structure and placement for prerequisites. The .NET README also incorrectly listed the CLI as a prerequisite despite the SDK bundling it.

Changes

  • All SDKs: Add "To use the SDK:" lead-in sentence before the prerequisites bullet list in dotnet, nodejs, python, go, rust, and java READMEs
  • .NET: Remove the CLI installation bullet from Prerequisites — the .NET SDK bundles the CLI, so it is not a consumer requirement
  • .NET: Move Prerequisites above Installation; clarify any .NET Standard 2.0-compatible implementation is supported (not just .NET 8)
  • Node.js / Python: Rename ## Requirements## Prerequisites; move before ## Installation
  • Java: Promote ### Runtime requirements (nested under Installation) to a top-level ## Prerequisites section
  • Go / Rust: Add new ## Prerequisites sections before Installation / Quick Start

Move the .NET README requirements section above installation, rename it to prerequisites, and clarify the runtime requirement as any .NET Standard 2.0-compatible implementation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 11, 2026 21:50
@scottaddie scottaddie requested a review from a team as a code owner June 11, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the .NET SDK README to surface runtime requirements up front and clarifies framework compatibility so users don’t incorrectly infer that .NET 8 is required for all use cases.

Changes:

  • Adds a new Prerequisites section before Installation.
  • Updates wording to state support for any .NET Standard 2.0-compatible implementation and links to Microsoft Learn guidance.
  • Removes the older “Requirements” section previously located near the bottom of the README.
Show a summary per file
File Description
dotnet/README.md Moves requirements into a Prerequisites section and clarifies .NET Standard 2.0 compatibility with an external reference link.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

This comment has been minimized.

@scottaddie scottaddie marked this pull request as draft June 11, 2026 21:58
@scottaddie

Copy link
Copy Markdown
Author

@copilot Update this PR to also address the suggestion in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot Update this PR to also address the suggestion in #1636 (comment)

Done. Applied the consistent ## Prerequisites pattern across all SDK READMEs in commit Apply consistent Prerequisites sections across all SDK READMEs:

  • Node.js: renamed ## Requirements## Prerequisites, moved before ## Installation
  • Python: same as Node.js
  • Java: promoted the ### Runtime requirements subsection (inside Installation) to a top-level ## Prerequisites section placed before Installation
  • Go: added a new ## Prerequisites section before ## Installation listing Go 1.24+ and CLI requirements
  • Rust: added a new ## Prerequisites section before ## Quick Start listing Rust 1.94.0+ and noting the bundled-cli default

Copilot AI changed the title Clarify .NET README prerequisites Standardize README prerequisites across all SDK languages Jun 11, 2026
@scottaddie scottaddie marked this pull request as ready for review June 11, 2026 22:06
@github-actions

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 871.4K

Comment thread python/README.md Outdated
@scottaddie

Copy link
Copy Markdown
Author

@copilot update this PR to address the suggestions in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot update this PR to address the suggestions in #1636 (comment)

Done. Updated python/README.md to change "GitHub Copilot CLI installed and accessible" to "GitHub Copilot CLI installed and in PATH (or provide a custom connection=RuntimeConnection.for_stdio(path=...))". This now matches the specificity pattern used by all other SDK READMEs.

@github-actions

This comment has been minimized.

@scottaddie

Copy link
Copy Markdown
Author

@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment)

Fixed in the latest commit — removed the stray trailing period from 1.0.55-5.1.0.55-5 in java/README.md.

@github-actions

This comment has been minimized.

@scottaddie

Copy link
Copy Markdown
Author

@copilot update the PR to address the minor nitpick mentioned in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot update the PR to address the minor nitpick mentioned in #1636 (comment)

Done. Updated Node.js, Python, and .NET Prerequisites sections to use `PATH` (code-formatted), matching Go and Java.

@github-actions

This comment has been minimized.

Comment thread dotnet/README.md

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the .NET issue, LGTM

Comment thread dotnet/README.md Outdated
…SDK READMEs

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Comment thread dotnet/README.md Outdated

## Prerequisites

To use the SDK:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot In each of the language files, update the "To use the SDK:" text to "To use the SDK, you'll need:"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — updated all six SDK READMEs to use "To use the SDK, you'll need:" in the latest commit.

…READMEs

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

@edburns edburns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Java

@scottaddie scottaddie requested a review from stephentoub June 15, 2026 17:10
Comment thread java/README.md

- Java 17 or later. **JDK 25 recommended**. The distributed jar is a multi-release jar (MR-JAR) and is compiled on JDK 25 with `maven.compiler.release` set to 17. This means, when run on JDK 25 and later, the SDK automatically uses virtual threads for its default internal executor.
- GitHub Copilot CLI 1.0.55-5. or later installed and in `PATH` (or provide custom `cliPath`)
- GitHub Copilot CLI 1.0.55-5 or later installed and in `PATH` (or provide custom `cliPath`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not bundle it with Java as well?

Comment thread nodejs/README.md
To use the SDK, you'll need:

- Node.js ^20.19.0 or >=22.12.0
- GitHub Copilot CLI installed and in `PATH` (or provide a custom `connection`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we bundle it for node as well?

Comment thread python/README.md
To use the SDK, you'll need:

- Python 3.11+
- GitHub Copilot CLI installed and in `PATH` (or provide a custom `connection=RuntimeConnection.for_stdio(path=...)`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we bundle it for python as well?

Comment thread rust/README.md
To use the SDK, you'll need:

- Rust 1.94.0 or later
- GitHub Copilot CLI: bundled by default via the `bundled-cli` feature (see [Features](#features)); or supply via `COPILOT_CLI_PATH`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to list it as a prereq given that it's bundled by default?

@github-actions

Copy link
Copy Markdown
Contributor

Cross-SDK consistency review ✅

This PR does an excellent job standardizing prerequisites structure across all six SDK implementations. Here's the consistency checklist:

Check Result
All 6 SDKs have a ## Prerequisites section
Consistent lead-in: "To use the SDK, you'll need:"
Section placed before Installation / Quick Start
.NET and Rust correctly omit the CLI requirement (bundled)
PATH consistently formatted as inline code

One minor observation (pre-existing, not introduced by this PR): java/README.md specifies a minimum CLI version (1.0.55-5 or later), while nodejs, python, and go READMEs list the CLI as a requirement without a version constraint. This was already present before this PR — it's just been moved from under ## Installation to the new ## Prerequisites section. If a minimum CLI version is meaningful for Java specifically, keeping it is fine; if it's meant to be universal, the other SDKs could eventually document the same floor. Either way, it's out of scope for this PR.

Overall, the structural changes are clean, symmetric, and consistently applied. No cross-SDK gaps to address.

Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 674.3K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants