Skip to content

Java: Use fixture for filtering diagnostics#21990

Open
jketema wants to merge 1 commit into
github:mainfrom
jketema:jketema/telemetry-prep
Open

Java: Use fixture for filtering diagnostics#21990
jketema wants to merge 1 commit into
github:mainfrom
jketema:jketema/telemetry-prep

Conversation

@jketema

@jketema jketema commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the Java label Jun 15, 2026
@jketema jketema marked this pull request as ready for review June 15, 2026 14:40
@jketema jketema requested a review from a team as a code owner June 15, 2026 14:40
Copilot AI review requested due to automatic review settings June 15, 2026 14:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Java buildless integration tests to opt into a shared diagnostics-filtering/checking mechanism by requesting the check_diagnostics_java pytest fixture in each test function signature.

Changes:

  • Add check_diagnostics_java fixture dependency to buildless-related Java integration tests.
  • Standardize buildless test entrypoints to ensure diagnostics are filtered/validated consistently during test execution.
Show a summary per file
File Description
java/ql/integration-tests/java/buildless/test.py Adds check_diagnostics_java fixture to the buildless smoke test.
java/ql/integration-tests/java/buildless-sibling-projects/test.py Adds check_diagnostics_java fixture to sibling-projects buildless test.
java/ql/integration-tests/java/buildless-proxy-maven/test.py Adds check_diagnostics_java fixture to buildless Maven-over-proxy test.
java/ql/integration-tests/java/buildless-proxy-gradle/test.py Adds check_diagnostics_java fixture to buildless Gradle-over-proxy test.
java/ql/integration-tests/java/buildless-maven/test.py Adds check_diagnostics_java fixture to buildless Maven test (build_mode none).
java/ql/integration-tests/java/buildless-maven-timeout/test.py Adds check_diagnostics_java fixture to buildless Maven timeout test.
java/ql/integration-tests/java/buildless-maven-multimodule/test.py Adds check_diagnostics_java fixture to buildless Maven multimodule test.
java/ql/integration-tests/java/buildless-maven-mirrorof/test.py Adds check_diagnostics_java fixture to buildless Maven mirrorOf test (build_mode none).
java/ql/integration-tests/java/buildless-maven-existing-settings-xml/test.py Adds check_diagnostics_java fixture to buildless Maven existing-settings.xml test (build_mode none).
java/ql/integration-tests/java/buildless-maven-executable-war/test.py Adds check_diagnostics_java fixture to buildless Maven executable WAR test.
java/ql/integration-tests/java/buildless-inherit-trust-store/test.py Adds check_diagnostics_java fixture to trust-store inheritance test.
java/ql/integration-tests/java/buildless-gradle/test.py Adds check_diagnostics_java fixture to buildless Gradle test.
java/ql/integration-tests/java/buildless-gradle-timeout/test.py Adds check_diagnostics_java fixture to buildless Gradle timeout test.
java/ql/integration-tests/java/buildless-gradle-classifiers/test.py Adds check_diagnostics_java fixture to buildless Gradle classifiers test.
java/ql/integration-tests/java/buildless-gradle-boms/test.py Adds check_diagnostics_java fixture to buildless Gradle BOMs test.
java/ql/integration-tests/java/buildless-erroneous/test.py Adds check_diagnostics_java fixture to buildless erroneous-project test.

Copilot's findings

  • Files reviewed: 16/16 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants