Skip to content

fix: replace npm install with npm ci (20260615-142501) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
securityeng-bot wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

fix: replace npm install with npm ci (20260615-142501) #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa21baf
fix: use lockfile-aware install commands
securityeng-bot[bot] Jun 15, 2026
8f13af9
fix: use lockfile-aware install commands
securityeng-bot[bot] Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

- name: Install
run: |
npm install
npm ci

- name: Format Check
run: |
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:

- name: Install
run: |
npm install
npm ci

- name: Build
run: |
Expand Down Expand Up @@ -118,15 +118,15 @@ jobs:
- name: Integration tests ESM
working-directory: ./test-integration/esm-project
run: |
npm install --install-links
npm ci --install-links
npm run test
env:
DOCKER_HOST: ${{ steps.engine.outputs.sock }}

- name: Integration tests CJS
working-directory: ./test-integration/cjs-project
run: |
npm install --install-links
npm ci --install-links
npm run test
env:
DOCKER_HOST: ${{ steps.engine.outputs.sock }}
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ FROM base AS install-base
WORKDIR /project
COPY . .
RUN --mount=type=cache,target=/root/.npm \
npm install
npm ci

FROM install-base AS build
RUN npm run build
Expand All @@ -33,12 +33,12 @@ COPY --link --from=build /project/test-integration/esm-project esm-project
RUN --mount=type=cache,target=/root/.npm \
cd cjs-project && \
npm install ../node-sdk && \
npm install && \
npm ci && \
npm test
RUN --mount=type=cache,target=/root/.npm \
cd esm-project && \
npm install ../node-sdk && \
npm install && \
npm ci && \
npm test

FROM scratch AS dist
Expand Down
Loading