feat(memory): add cross-process locking and atomic writes for sqlite#3114
Open
yunasora wants to merge 1 commit into
Open
feat(memory): add cross-process locking and atomic writes for sqlite#3114yunasora wants to merge 1 commit into
yunasora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3022
Implementation Details & Context
During the implementation, I aligned the changes with the existing codebase architecture and made a few adjustments based on the repository's current state:
Database Configuration & Connection Pool:
PRAGMA journal_mode=WAL,busy_timeout=5000, andSetMaxOpenConns(1)) are already centrally configured insqliteutil/sqlite.go(which corresponds to thepkg/memory/database/sqlite/db.gomentioned in the checklist).sqliteutil.OpenDBalready enforces serialized writes viaSetMaxOpenConns(1)while leaving read paths unlocked. WAL seamlessly handles the read/write concurrency.Cross-Platform File Lock:
add/update/delete) inside theFileLockboundary across Linux, macOS, and Windows.Drift Guard Note:
FileLockboundary, the upcoming drift guard feature can be safely integrated into this perimeter later.All cross-platform compilation checks and
go test -racefor memory/database modules have passed. Ready for review!