[APS-19381] fix: harden .npmrc with supply-chain security directives#35
Closed
Rohannagariya1 wants to merge 2 commits into
Closed
[APS-19381] fix: harden .npmrc with supply-chain security directives#35Rohannagariya1 wants to merge 2 commits into
Rohannagariya1 wants to merge 2 commits into
Conversation
- Add ignore-scripts, strict-ssl, save-exact, engine-strict, legacy-peer-deps=false, audit-level=high - Preserve existing package-lock=true - Public repo: access=restricted intentionally omitted Resolves: APS-19381 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
Not needed on sample repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: APS-19381
Issue
The repo's
.npmrcfailed the weekly supply-chain.npmrcaudit (SC-12282) — it only containedpackage-lock=trueand was missing the required hardening directives.Root Cause
Missing npm hardening directives that protect against malicious lifecycle scripts, TLS downgrade, version drift, and incompatible engines.
Fix Applied
Added the 6 required directives while preserving the existing
package-lock=trueline:This is a public repo, so
access=restrictedis intentionally omitted.Testing
npm installsucceeds (exit 0):added 969 packages, audited 970.ignore-scripts=truecorrectly skips thepostinstall(npm update browserstack-node-sdk) — no native deps in this repo, so this is acceptable and the install completes cleanly.enginesfield in package.json, soengine-strict=truehas no adverse effect.Jira Ticket
https://browserstack.atlassian.net/browse/APS-19381
Checklist
npm installvalidated with directives.npmrcchange, no dependency/SDK changes)