[fix](case) test_admin_compact_table: count distinct tablets for multi-replica clusters#64509
Open
shuke987 wants to merge 1 commit into
Open
Conversation
…i-replica clusters SHOW TABLETS returns one row per (tablet, replica). On a multi-replica test cluster (e.g. force_olap_table_replication_num=3) a table with BUCKETS 1 yields 3 rows, so assertEquals(1, tablets.size()) fails (expected 1, got 3) -- the assertion implicitly assumes a single replica. Assert on the distinct tablet count instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a multi-replica test cluster (e.g.
force_olap_table_replication_num=3),SHOW TABLETSreturns one row per (tablet, replica). A table created withBUCKETS 1therefore yields 3 rows, soassertEquals(1, tablets.size())fails (expected 1, got 3). The assertion implicitly assumes a single replica.Fix
Assert on the distinct tablet count:
tablets.collect { it.TabletId }.unique().size(). The subsequent code already picks one replica viatablets[0].Verification
Ran the suite on a branch-4.1 local cluster (3 FE + 4 BE, force-3 replicas) — passes.
🤖 Generated with Claude Code