refactor(hash-aggr): Migrate existing tests on GroupsHashAggregateStream#22953
Merged
Conversation
alamb
approved these changes
Jun 15, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me -- thank you @2010YOUY01
Contributor
|
Since this PR just adds new tests, I will merge it now to keep things moving -- we can update the tests as a follow on PR if anyone woudl like changes |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #22710
Rationale for this change
The goal is after we have fully migrated from the old
row_hash.rs, the existing UTs should be kept. Specifically, all tests that includeGroupedHashAggregateStreamThere are 3 previous PRs for the migration have been merged, some existing UTs are applicable to them, this PR migrated those tests to the new implementation.
The test migration includes:
GroupedHashAggregateStreamtoPartialHashAggregateStream(or other stream in new impl)This PR moved 2 applicable UTs, and updated the comments for all the tests moved previously.
(Just some random thoughts, in general I don't think it's a good idea to write tests against low-level utilities like
GroupedHashAggregateStream, all tests should better be at SQL level, or at least atExecutionPlanlevel, so their test goal are more likely to survive refactors)What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?