fix: include <any> in sstream_workaround.h to fix C++17 build#3346
Open
Felix-Gong wants to merge 1 commit into
Open
fix: include <any> in sstream_workaround.h to fix C++17 build#3346Felix-Gong wants to merge 1 commit into
Felix-Gong wants to merge 1 commit into
Conversation
chenBright
reviewed
Jun 14, 2026
chenBright
left a comment
chenBright
left a comment
Contributor
There was a problem hiding this comment.
I think using -fno-access-control, like in test/BUILD.bazel, would be more reasonable.
Line 26 in 1725896
chenBright
reviewed
Jun 14, 2026
| # if __cplusplus >= 201703L | ||
| # include <any> | ||
| # endif | ||
| # define private public |
Contributor
There was a problem hiding this comment.
Using -fno-access-control instead of # define private public?
Contributor
Author
|
Good point! I'll update the PR to:
The Bazel build already uses |
Contributor
|
test/Makefile also needs to be updated. Line 21 in 1725896 |
Replace the -Dprivate=public -Dprotected=public macro hack with the -fno-access-control compiler flag in both CMake and Makefile builds. The macro approach caused redeclaration errors with standard library headers (<sstream>, <any>, etc.) that use private access specifiers internally. -fno-access-control is a GCC/Clang compiler flag that cleanly disables access control checking without affecting header parsing, eliminating the need for the sstream_workaround.h workaround logic. The Bazel build already uses -fno-access-control at test/BUILD.bazel, so this makes CMake and Makefile builds consistent with Bazel. Signed-off-by: Felix-Gong <gongxiaofei24@iscas.ac.cn>
Felix-Gong
force-pushed
the
fix-std-any-cpp17
branch
from
3354e3d to
5b9b747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::anyredeclaration error when building tests with C++17 and-Dprivate=publicsstream_workaround.halready handles the same issue for<sstream>, but does not protect<any>Fixes #3345
Test plan
-Dprivate=publicstd::any)