GH-38849: [C++][Parquet] Add support for list view and large list view#50160
Open
HuaHuaY wants to merge 5 commits into
Open
GH-38849: [C++][Parquet] Add support for list view and large list view#50160HuaHuaY wants to merge 5 commits into
HuaHuaY wants to merge 5 commits into
Conversation
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
wgtmac
reviewed
Jun 15, 2026
| } | ||
|
|
||
| TEST(ArrowReadWrite, LargeListView) { | ||
| auto values = ArrayFromJSON(::arrow::int32(), "[1, 2, 3, 4, 5]"); |
Member
There was a problem hiding this comment.
Can we use a single test by parameterizing schema and table to reduce duplicated lines? I don't remember if RecordBatchFromJson supports list view natively.
Contributor
Author
There was a problem hiding this comment.
I don't think there's much duplicate code here, and it's not easy to merge. Because without enabling store_schema, large list type requires manually changing the inner array name from item to element.
github-actions
Bot
added
awaiting committer review
wgtmac
reviewed
Jun 15, 2026
wgtmac
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Allow us to write an arrow list view array into a parquet file and read list view type from parquet.
What changes are included in this PR?
We will sort the list views based on the offsets before inserting the array in Parquet writer, and generate a size array in Parquet reader.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.