Skip to content

fix(aria/listbox): Add option to contral the value should be sync wit… #33400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baptistemoreau14 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(aria/listbox): Add option to contral the value should be sync wit… #33400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/aria/listbox/listbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ export class Listbox<V> implements OnDestroy {
/** Whether focus should wrap when navigating. */
readonly wrap = input(true, {transform: booleanAttribute});

/** Whether the value should always be in sync with the available options */
readonly syncValue = input(true, {transform: booleanAttribute});

/**
* Whether to allow disabled items to receive focus. When `true`, disabled items are
* focusable but not interactive. When `false`, disabled items are skipped during navigation.
Expand Down Expand Up @@ -190,8 +193,9 @@ export class Listbox<V> implements OnDestroy {
write: () => {
const items = inputs.items();
const value = untracked(() => this.value());
const syncValue = untracked(() => this.syncValue());

if (items && value.some(v => !items.some(i => i.value() === v))) {
if (syncValue && items && value.some(v => !items.some(i => i.value() === v))) {
this.value.set(value.filter(v => items.some(i => i.value() === v)));
}
},
Expand Down
Loading