Stabilize login modal context during dev HMR

[tannerlinsley]

Summary

Stabilizes the login modal React context object during browser development so Vite/Fast Refresh does not leave preserved consumers reading from a freshly-created context while the provider still belongs to the previous module instance.

Impact

This should stop the intermittent dev-only useLoginModal must be used within a LoginModalProvider error that disappears after a manual refresh. The provider misuse guard still remains for real missing-provider bugs.

Validation

• pnpm test
• Commit hook reran pnpm run format && pnpm run test

Summary by CodeRabbit

• Bug Fixes
  • Fixed context preservation during development hot module reloading to maintain state across reloads.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7fb58089-ea9c-4b9d-a302-fa08ce743880

📥 Commits

Reviewing files that changed from the base of the PR and between 8d47532 and 7ee1af2.

📒 Files selected for processing (1)

• src/contexts/LoginModalContext.tsx

---

📝 Walkthrough

Walkthrough

LoginModalContext initialization is changed to reuse a globalThis.__tanstackLoginModalContext singleton in import.meta.env.DEV browser environments, preserving context identity across HMR reloads. A declare global block is added to type the global variable. Production and non-browser environments still create a fresh context.

Changes

HMR-stable LoginModalContext

Layer / File(s)	Summary
Global singleton context for HMR stability src/contexts/LoginModalContext.tsx	Adds a declare global type for __tanstackLoginModalContext, replaces the unconditional React.createContext call with a conditional that reads from and writes back to globalThis when import.meta.env.DEV and typeof window !== 'undefined', falling back to a fresh context otherwise.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 In dev mode I hop, reload after reload,
My context stays put — same identity, same road.
A global is set so I never get lost,
No stale providers, no HMR cost.
The modal remembers me, warm and at home! 🏠

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Stabilize login modal context during dev HMR' directly and specifically describes the main change: stabilizing the login modal context during development HMR, which matches the primary objective of the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch taren/fix-login-modal-hmr-context

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}