[terminal-stylist] Terminal Stylist Analysis: Console Output Patterns in pkg/

[github-actions[bot]]

Overview

Analysis of console output patterns across 915 non-test Go files in pkg/, covering Lipgloss (charm.land/lipgloss/v2), Huh (charm.land/huh/v2), and internal pkg/console + pkg/styles abstractions.

Key Metrics

Metric	Count
Non-test Go files in pkg/	915
fmt.Print* calls in pkg/cli/	1,725
console.* calls in pkg/cli/	1,866
Files with direct lipgloss import	7
Files using Huh	13
Adaptive color constants	11
Pre-configured Lipgloss styles	24

Architecture

Layered output system:

• pkg/styles/theme.go — 11 adaptive compat.AdaptiveColor constants (Dracula-inspired dark / high-contrast light) + 24 pre-configured Lipgloss styles
• pkg/styles/huh_theme.go — Custom Huh ThemeFunc mapping the shared palette to form field styles
• pkg/console/ — Abstraction layer (26 files): TTY detection, format helpers, progress bar, spinner, table renderer, interactive prompts
• pkg/cli/ — 319 primary consumer files

---

✅ Strengths

Expand

1. Adaptive Color System — 11 compat.AdaptiveColor constants with distinct light/dark hex values; auto-adapts to terminal background.
2. TTY Detection — applyStyle() in console.go gates all Lipgloss rendering. ANSI codes in terminal.go gated by tty.IsStderrTerminal().
3. Centralized Styles — 24 semantic named styles (styles.Error, styles.TableHeader, etc.) prevent ad-hoc color choices.
4. Huh Theming — All 13 Huh-using files apply .WithTheme(styles.HuhTheme).WithAccessible(console.IsAccessibleMode()).
5. Accessibility Mode — IsAccessibleMode() detects ACCESSIBLE, TERM=dumb, NO_COLOR env vars.
6. Non-TTY Fallbacks — ConfirmAction falls back to text prompt; ProgressBar renders plain-text percentages.
7. Top console.Format adoption* — FormatInfoMessage: 643 calls; FormatWarningMessage: 469; FormatSuccessMessage: 214.
8. Windows Safety — theme.go skips terminal probing on Windows for redirected handles.
9. Lipgloss Table — console.RenderTable() wraps lipgloss/table with TTY-aware styleFunc.
10. Progress Bar — bubbles/progress with adaptive ColorPurple→ColorInfo gradient + non-TTY fallback.

---

⚠️ Issues Found

High: Unstyled Error Report Output — compile_stats.go

20 raw fmt.Fprintf(os.Stderr, ...) calls for failure lists and recovery steps bypass the console package:

// ❌ Current
fmt.Fprintf(os.Stderr, "  ✗ %s\n", filepath.Base(failure.Path))
fmt.Fprintf(os.Stderr, "  💡 Recovery plan:\n")
// ✅ Better
fmt.Fprintln(os.Stderr, console.FormatErrorMessage("  ✗ "+filepath.Base(failure.Path)))
fmt.Fprintln(os.Stderr, console.FormatInfoMessage("  💡 Recovery plan:"))

Surrounding code already uses console.FormatErrorMessage(), creating inconsistent visual hierarchy.

High: No Styling at All — outcomes_history.go

10 plain fmt.Fprintf(os.Stderr, ...) calls — zero use of the console package. The bucket table is a prime candidate for console.RenderTable() and the source heading for console.FormatSectionHeader().

Medium: Mixed Styled/Unstyled Sub-items — trial_confirmation.go

Top-level plan steps use console.FormatInfoMessage() but nested sub-items (a., b.) are raw:

// ✅ Parent styled
fmt.Fprintf(os.Stderr, console.FormatInfoMessage("  %d. Execute %s %d times\n"), ...)
// ❌ Sub-items plain
fmt.Fprintf(os.Stderr, "     a. Execute %s\n", workflowName)

Medium: Verbose Debug Without Flag — token_usage.go

4+ debug messages written unconditionally, no verbose gate, no console.FormatVerboseMessage():

// ❌ Always printed
fmt.Fprintf(os.Stderr, "  Found token usage file: %s (%d bytes)\n", filepath.Base(filePath), fileInfo.Size())
// ✅ Better
console.LogVerbose(verbose, fmt.Sprintf("Found token usage file: %s (%d bytes)", ...))

Low: Inline Lipgloss in CLI — compile_schedule_calendar.go

6 inline lipgloss.NewStyle() calls in intensityStyle() bypass pkg/styles. These should be named constants in pkg/styles/theme.go.

Low: Unstyled Welcome Banner — terminal.go

ShowWelcomeBanner() emits plain emoji text; should use applyStyle(styles.Header, ...) for consistency.

---

Huh Form Usage Summary

All 13 Huh-using files apply WithTheme(styles.HuhTheme) and WithAccessible(console.IsAccessibleMode()) consistently. ✅

Lipgloss Usage Summary

File	Pattern	Assessment
pkg/styles/theme.go	Defines adaptive colors + named styles	✅ Canonical
pkg/console/console.go	TTY-gated applyStyle()	✅ Best practice
pkg/cli/compile_schedule_calendar.go	6 inline lipgloss.NewStyle()	⚠️ Should use pkg/styles
pkg/cli/status_command.go	lipgloss/tree	✅ Correct
pkg/cli/mcp_inspect.go	lipgloss/tree	✅ Correct

References:

• §27495151789

Generated by 💄 Terminal Stylist · 544.6 AIC · ⌖ 13 AIC · ⊞ 21K · ◷

• expires on Jun 15, 2026, 2:00 AM UTC-08:00

[pelikhan]

/plan

[github-actions[bot]]

🚀 Plan Command has started processing this discussion comment

[github-actions[bot]]

This discussion has been marked as outdated by Terminal Stylist.

A newer discussion is available at Discussion #39355.