Skip to content

Commit 4f1d6f4

Browse files
felickzCopilot
andcommitted
Fix test comments: replace GOOD/BAD markers with flow source descriptions
Per review feedback, GOOD/BAD markers don't apply to flow source enumeration tests. Use descriptive comments instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 23567eb commit 4f1d6f4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

csharp/ql/test/library-tests/dataflow/flowsources/aspremote/AspRemoteFlowSource.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void MyActionMethod(string param) { }
6767
// Razor Page handler tests
6868
public class MyPageModel : Microsoft.AspNetCore.Mvc.RazorPages.PageModel
6969
{
70-
// BAD: handler method parameters are user-controlled
70+
// Handler method parameters are remote flow sources
7171
public void OnGet(string id) { }
7272

7373
public void OnPost(string command, int count) { }
@@ -78,10 +78,10 @@ public void OnPut(string value) { }
7878

7979
public void OnDelete(string itemId) { }
8080

81-
// GOOD: not a handler method (doesn't start with On)
81+
// Not a handler method — does not start with "On", so not a flow source
8282
public void GetUser(string userId) { }
8383

84-
// GOOD: marked with NonHandler attribute
84+
// Excluded by [NonHandler] attribute, so not a flow source
8585
[Microsoft.AspNetCore.Mvc.RazorPages.NonHandlerAttribute]
8686
public void OnGetNonHandler(string param) { }
8787
}

0 commit comments

Comments
 (0)