Python: drop MISSING: keyword from inline annotations that now match

After the dataflow flip to the new shared CFG + SSA, several inline
test annotations of the form `# $ MISSING:<tag>` are no longer
accurate: the new dataflow now produces the documented result, and
the test suite was flagging this with `Fixed missing result: <tag>`
entries in `.expected` files.

Per the inline-expectation convention, the `MISSING:` keyword should
be dropped (so the annotation becomes a regular positive assertion)
rather than blessing the `.expected` to absorb the `Fixed missing`
diagnostic.

Affected:

- `experimental/library-tests/CallGraph-type-annotations/type_annotations.py:29` (`tt=Foo.method`)
- `experimental/library-tests/CallGraph/code/conditional_in_argument.py:18` (`tt=X.bar`)
- `experimental/library-tests/CallGraph/code/funky_regression.py:15` (`tt=Wat.f2`)
- `library-tests/frameworks/lxml/taint_test.py:83` (`tainted`)
- `query-tests/Resources/FileNotAlwaysClosed/resources_test.py:49,141,237` (`Alert`)

The `inline-taint-test-demo/taint_test.py:41` case is intentionally
left in place: that file is a meta-test demonstrating the
inline-expectation framework's behaviour when both `# $ tainted` and
`MISSING: tainted` are attached to the same line.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: yoff

python/ql/test/experimental/library-tests/CallGraph-type-annotations/InlineCallGraphTest.expected

@@ -1,7 +1,6 @@
 testFailures
 | type_annotations.py:6:16:6:32 | Comment # $ tt=Foo.method | Missing result: tt=Foo.method |
 | type_annotations.py:16:16:16:32 | Comment # $ tt=Foo.method | Missing result: tt=Foo.method |
-| type_annotations.py:29:5:29:14 | Attribute() | Fixed missing result: tt=Foo.method |
 debug_callableNotUnique
 pointsTo_found_typeTracker_notFound
 typeTracker_found_pointsTo_notFound

python/ql/test/experimental/library-tests/CallGraph-type-annotations/type_annotations.py

@@ -26,7 +26,7 @@ def test_variable_annotation():
     x = eval("Foo()")
     x : Foo
     # Currently fails because there is no flow from the class definition to the type annotation.
-    x.method() # $ MISSING: tt=Foo.method
+    x.method() # $ tt=Foo.method
 
 def test_no_variable_annotation():
     x = eval("Foo()")

python/ql/test/experimental/library-tests/CallGraph/InlineCallGraphTest.expected

@@ -1,6 +1,4 @@
 testFailures
-| code/conditional_in_argument.py:18:5:18:11 | Attribute() | Fixed missing result: tt=X.bar |
-| code/funky_regression.py:15:9:15:17 | Attribute() | Fixed missing result: tt=Wat.f2 |
 debug_callableNotUnique
 pointsTo_found_typeTracker_notFound
 | code/class_attr_assign.py:10:9:10:27 | Attribute() | my_func |

python/ql/test/experimental/library-tests/CallGraph/code/conditional_in_argument.py

@@ -15,7 +15,7 @@ def func(cond=True):
 
     # the conditional in the argument makes us stop tracking the class instance :|
     x.foo(1 if cond else 0) # $ pt,tt=X.foo
-    x.bar() # $ pt=X.bar MISSING: tt=X.bar
+    x.bar() # $ pt=X.bar tt=X.bar
 
 
 func() # $ pt,tt=func

python/ql/test/experimental/library-tests/CallGraph/code/funky_regression.py

@@ -12,7 +12,7 @@ def func(self, foo):
         except Exception as e:
             raise e
 
-        self.f2() # $ pt=Wat.f2 MISSING: tt=Wat.f2
+        self.f2() # $ pt=Wat.f2 tt=Wat.f2
 
 
 # ==============================================================================

python/ql/test/library-tests/frameworks/lxml/InlineTaintTest.expected

@@ -2,5 +2,4 @@ argumentToEnsureNotTaintedNotMarkedAsSpurious
 untaintedArgumentToEnsureTaintedNotMarkedAsMissing
 | taint_test.py:133:13:133:35 | taint_test.py:133 | ERROR, you should add `# $ MISSING: tainted` annotation | tree_arg.getroot().text |
 testFailures
-| taint_test.py:83:13:83:19 | ch.text | Fixed missing result: tainted |
 | taint_test.py:133:37:133:82 | Comment # $ tainted # Type tracking from the type hint | Missing result: tainted |

python/ql/test/library-tests/frameworks/lxml/taint_test.py

@@ -80,7 +80,7 @@ def test():
     for ch in elem:
         ensure_tainted(
             ch,  # $ tainted
-            ch.text  # $ MISSING: tainted # API node getASubscript() appears to not consider things like for loops 
+            ch.text  # $ tainted
         )
 
     buf = io.StringIO(src)

python/ql/test/query-tests/Resources/FileNotAlwaysClosed/FileNotAlwaysClosed.expected

@@ -30,14 +30,11 @@ testFailures
 | resources_test.py:20:10:20:25 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:30:14:30:29 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:39:14:39:29 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
-| resources_test.py:49:14:49:29 | File may not be closed if $@ raises an exception. | Fixed missing result: Alert |
 | resources_test.py:58:14:58:29 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:69:11:69:26 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:79:11:79:26 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:91:11:91:26 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
-| resources_test.py:141:11:141:26 | File may not be closed if $@ raises an exception. | Fixed missing result: Alert |
 | resources_test.py:182:15:182:54 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:225:11:225:26 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
-| resources_test.py:237:11:237:26 | File may not be closed if $@ raises an exception. | Fixed missing result: Alert |
 | resources_test.py:252:11:252:25 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |
 | resources_test.py:275:10:275:35 | File may not be closed if $@ raises an exception. | Unexpected result: Alert |

python/ql/test/query-tests/Resources/FileNotAlwaysClosed/resources_test.py

@@ -46,7 +46,7 @@ def closed7():
 def not_closed8():
     f8 = None
     try:
-        f8 = open("filename") # $ MISSING:Alert # not closed on exception
+        f8 = open("filename") # $ Alert # not closed on exception
         f8.write("Error could occur")
     finally:
         if f8 is None: # We don't precisely consider this condition, so this result is MISSING. However, this seems uncommon.
@@ -138,7 +138,7 @@ def may_raise():
 
 #Not handling all exceptions, but we'll tolerate the false negative
 def not_closed17():
-    f17 = open("filename") # $ MISSING:Alert # not closed on exception
+    f17 = open("filename") # $ Alert # not closed on exception
     try:
         f17.write("IOError could occur")
         f17.write("IOError could occur")
@@ -234,7 +234,7 @@ def closed21(path):
 
 
 def not_closed22(path):
-    f22 = open(path, "wb") # $ MISSING:Alert # not closed on exception
+    f22 = open(path, "wb") # $ Alert # not closed on exception
     try:
         f22.write(b"foo")
         may_raise()